Closed FalcoSuessgott closed 6 months ago
@FalcoSuessgott sorry for the wait, I was away, and the team is swamped. Thanks a lot for your contribution to kubefirst!
I'll ask the engineering team to review your PR, but can you please sign your commits please https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits as we won't be able to merge them without it.
Hi @fharper! aprreciate your time. Signed all commits now and rebased against main :)
Thanks @FalcoSuessgott: if you want to DM me on our Slack community, I'll send you some swag as a small thank you gesture for your PR!
depends_on
in all vault modulesterraform format
for all terraform dirs.Makefile
withfmt
andvalidate
target to perform these options conviently locally (make validate
catched some errors and warning that we might wanna fix in another PR.)terraform format
recursive option in CI.vault_generic_secret
block usingfor_each
, so its less redundantThis PR is ready for review, would love some feedback if somebody has the time and patience