search

konstructio / gitops-template

upstream template for your open source gitops repository
MIT License
67 stars 56 forks source link

feat : custom repo for civo #778

Open jokestax opened 2 months ago

jokestax commented 2 months ago

we can now deploy multiple repos on same organistation using below flags :

"--gitopsRepoName" metaphorRepoName "adminTeamName" "developerTeamName"

but we have to use kubefirst repo branch "feat-custom-repo" and kubefirst-api repo branch "feat-custom-repo" until its merged into main

mrsimonemms commented 2 months ago

This is quite a large number of files being changed - how can I test it?

jokestax commented 2 months ago

This is for all clouds,may be we can distribute the work for testing?

fharper commented 2 months ago

@jokestax: as a rule of thumb, before asking for review, always try to have your branch up to date with main even if GitHub report no conflict. It only mean there is no code conflict, but other changes can influence yours, and the other way around.

Of course, changes in main can happen after, so in that case, the tester can merge main before testing, or ask you to do it if there are any detected conflicts. It's a best practice, so sharing so you know :)

jokestax commented 2 months ago

Okay @fharper ,got it :)