konstructio / gitops-template

upstream template for your open source gitops repository
MIT License
67 stars 56 forks source link

fix: force replace Job during a sync #792

Closed muse-sisay closed 1 month ago

muse-sisay commented 1 month ago

Description

A Job resource is an immutable resource. Changes to spec.template causes a sync error. Add annotation to force replaces Job resources.

Remove the sync option "replace" from vault-wait ArgoCD app and add to the Job resource as SA and CRB resources do not need to be replaced.

Related Issue(s)

https://github.com/kubefirst/kubefirst/issues/2264

How to test

Provision a management cluster and verify vault-wait job is healthy.

johndietz commented 1 month ago

let's get this fix into the other stacks too. don't care if that's this pr or a follow up one. awesome quick find and fix @muse-sisay thank you! 🚀

muse-sisay commented 1 month ago

Added changes to all other stacks except to K3d and k3s, as they are missing vault-wait app.