konstructio / kubefirst-api

Kubefirst API that serves console frontend
MIT License
10 stars 14 forks source link

Templating Update #358

Open dahendel opened 3 months ago

dahendel commented 3 months ago

This PR adds go templating support while aiming to not introduce any breaking changes to the current gitops-templates repository or code functionality.

It also adds detokenize_test.go which clones a template repo and then executes the DetokenizeGitGitops function calls on the supplied path.

Introduces Tokens interface to help reduce duplicate code.

The code works as follows:

DrummyFloyd commented 3 months ago

seems really cool like this , even if the delimiter [[ is bit weird to see ^^.

overall, you should try to clean a lil bit all the tabs/ new line , it's kinda hard to read clearly all the changes. but i think the breaking change is quite huge, don't know how K1 teams will handle this , through gitops-template

dahendel commented 3 months ago

@DrummyFloyd thanks for the feedback. This still works with all the current templating in place, to include the cert manager annotations. I am working on cleaning it up a bit more but wanted feedback before I went too far.