konstructio / kubefirst-api

Kubefirst API that serves console frontend
MIT License
10 stars 14 forks source link

Vultr fix #397

Closed jokestax closed 1 month ago

jokestax commented 2 months ago

Description

Implemented a timout error as cluster deployment takes some time to get deployed,otherwise it wont wait for the cluster and returns an connection refused error

How to test

kubefirst beta vultr create --alerts-email --github-org --domain-name --gitops-template-branch patch-1 --cluster-name --gitops-template-url https://github.com/Seven45/gitops-template

fharper commented 2 months ago

@patrickdappollonio you also tested this PR since you approved it, not just checked the code? Just want to be sure as I won't test it since you approved.

patrickdappollonio commented 2 months ago

We made a unit test, but I don't think @jokestax shared it. Might need the human test instead.

jokestax commented 2 months ago

It needs a manual test :)

fharper commented 2 months ago

All PRs need to be tested in a way or another (often E2E) before we approved them, not just code reviews. I assumed it was done when approved, but no worries, I'll try to find time today to test it also :)

fharper commented 1 month ago

When running it, I got this error.

CleanShot 2024-08-14 at 10 22 11@2x

Not much more information in the logs.

CleanShot 2024-08-14 at 10 23 15@2x

Any idea if it's a code 18 or something in the code?

jokestax commented 1 month ago

Ohh when you are trying to run api locally there is new change done ,we have export K1_CONSOLE_REMOTE_URL="http://localhost:3000"

fharper commented 1 month ago

Oh OK, we should add this to the . env file if not already done. I will give it another try, thanks.

patrickdappollonio commented 1 month ago

@mrsimonemms this might be good to have in the .devcontainer so instead of having people run the long command I see in @fharper's screenshot, it could simply be run through the container.

patrickdappollonio commented 1 month ago

Oh wait, maybe that's kubefirst, not kubefirst-api, my bad.