search

konstructio / kubefirst-api

Kubefirst API that serves console frontend
MIT License
10 stars 14 forks source link

Sje/taskrunner #415

Closed mrsimonemms closed 2 weeks ago

mrsimonemms commented 1 month ago

Description

Related Issue(s)

Fixes #

How to test

patrickdappollonio commented 1 month ago

I think I also noticed some files were not gofmt'd. If you can, configure your editor to do formats on save, it saves a good chunk of time.

mrsimonemms commented 1 month ago

I think I also noticed some files were not gofmt'd. If you can, configure your editor to do formats on save, it saves a good chunk of time.

This is an unfinished proof-of-concept. Please avoid reviewing until in "ready".

It is a good example of why we need to get the pre-commit hooks in place.

patrickdappollonio commented 1 month ago

This is an unfinished proof-of-concept. Please avoid reviewing until in "ready".

I would politely disagree 😆 Just think about it, I would prefer to provide you context and feedback early and often versus having anyone go write 5000 lines of code just to be told after "this is great, but there are a few challenges we cannot bypass, so we'll have to either rewrite those 5k or hold off until X".

I would prefer to provide you with feedback that's short and actionable instead of one big wall of processing that would warrant you to change an algorithm 30 times before it's good. Early feedback is always, always encouraged!

It is a good example of why we need to get the pre-commit hooks in place.

Once this is merged: https://github.com/konstructio/kubefirst-api/pull/391, you won't be able to do it anymore, pre-commits or not in place, which is going to be super nice!