Make Azure DNS resource group is an optional parameter

konstructio / kubefirst

The Kubefirst Open Source Platform

https://kubefirst.konstruct.io/docs

MIT License

1.81k stars 142 forks source link

Make Azure DNS resource group is an optional parameter #2330

Open mrsimonemms opened 3 days ago

mrsimonemms commented 3 days ago

What is your feature idea?

The Golang SDK for Azure implied that the DNS zone needed a resource group to be found. The Terraform docs (which uses the Azure SDK) have it as an optional field.

See if we can do the same

Why is it needed?

Reduce input variables/complexity

Is this missing feature preventing you from using kubefirst?

[ ] Yes

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Tasks

[ ] #2337
[ ] #2338
[ ] #2340

linear[bot] commented 3 days ago

KON-48 Investigate if Azure DNS resource group name is actually required

mrsimonemms commented 3 days ago

My guess is that Terraform searches for a list of resource groups and then searches for the domain name in each one, stopping after the first true. I did look at this originally and I think the resource group was a reasonably slow API call, but some time-boxed investigation won't hurt.

If this is the case, this will require changes to the CLI, API and the required fields in the Console installer.