Return vacuum chunk instead of out of bounds

konstructs / client

A voxel based game client.

http://www.konstructs.org

MIT License

48 stars 8 forks source link

Return vacuum chunk instead of out of bounds #200

Closed petterarvidsson closed 7 years ago

petterarvidsson commented 7 years ago

In world, when accessing chunks via block positions, return vacuum chunk instead of throwing exception when a chunk is not found
Change "chunk" method to "chunk_opt" that returns an option of chunk data instead to be used when code needs to know if a chunk was not fetched yet

petterarvidsson commented 7 years ago

@caseymcc This is an attempt to fix the bug described in #199. It treats any chunk that was not fetched from the server yet as containing only vacuum blocks. Does it help with your problem? Be sure to run it against the master/HEAD of the server or it may not work as expected.

@nsg please take a look as well.

caseymcc commented 7 years ago

Keeps the program from crashing but screen stays black. Likely something between the server and client. I am not running a local server so connecting to play.konstructs.org.

petterarvidsson commented 7 years ago

@caseymcc only the latest stable client release works with play.konstructs.org (in this case https://github.com/konstructs/client/releases/tag/6). If you want to try out the latest version of the client, you usually need to run also the latest version of the server (that is master/HEAD of the server repository). You need to follow the instructions here: https://github.com/konstructs/server#building

Alternatively, @nsg sometimes runs a development server at dev.konstructs.org, it seems to be currently down though.

nsg commented 7 years ago

dev.konstructs.org is back online again

petterarvidsson commented 7 years ago

@caseymcc If you are interested in the development of the client, you can also join us in the gitter chat room.

nsg commented 7 years ago

@petterarvidsson I think we can merge this, looks good :+1: