search

konstructs / client

A voxel based game client.
http://www.konstructs.org
MIT License
48 stars 8 forks source link

Cleanbuild snap #213

Closed nsg closed 7 years ago

nsg commented 7 years ago

This is what I had to do to get a cleanbuild to compile, gcc-4.8 and g++-4.8 are probably redundant considering that cmake uses GCC 5.2 (or was it 5.3?) from build-essential.

What do you think @petterarvidsson, try to pin it to 4.8 or should we just use the latest available?

Another thought, considering that we can't include the the local checkout (source: ..) from a cleanbuild, maybe it makes more sense to move the snapcraft buildfiles to their own repo?

petterarvidsson commented 7 years ago

@nsg I don't understand why you required libglfw-dev? There must be some serious bug if that is required. The glfw included with nano-gui should be used.

petterarvidsson commented 7 years ago

@sng Could make sense to separate these files as you say.

petterarvidsson commented 7 years ago

@nsg Regarding compiler I'd say let's go with the ones from build essentials. It's anyway up to cmake and as you say it is very likely to choose the one from build essentials.

nsg commented 7 years ago

@petterarvidsson

libglfw-dev: Probably some dependency, not sure.

nsg commented 7 years ago

@petterarvidsson rebased and squashed this to a single commit, this is the code that's in snap's stable channel, can we merge this?