search

konstruktoid / ansible-role-docker-rootless

Ansible role to install a rootless Docker server
Apache License 2.0
68 stars 22 forks source link

Docker compose is hardcoded for x86_64 #402

Closed daladim closed 4 months ago

daladim commented 4 months ago

Thanks for this great and convenient Ansible role!

This line hardcodes Docker-compose for x86_64 bits. I think that should be good to have an e.g. docker_arch variable so that the caller can tweak it.

I just installed on an ARM server by manually downloading and overwriting the docker-compose executable. Sorry I did not take time to do an MR (I'll let you choose this variable name to avoid bikeshedding :D ) but that would be a great addition for this role

konstruktoid commented 4 months ago

Hi @daladim and thanks. Adding an arch var makes a lot of sense, and I'll add it later today.

konstruktoid commented 4 months ago

https://github.com/konstruktoid/ansible-role-docker-rootless/pull/403 has been merged

daladim commented 4 months ago

Thanks!