search

konsumer / gatsby-starter-bootstrap-netlify

Bootstrap and netlify CMS starter for Gatsby
MIT License
63 stars 22 forks source link

Issue #8 fix - Reallocation of netlify-identity script #9

Closed FMGordillo closed 6 years ago

FMGordillo commented 6 years ago

Sorry, The next commits 65623c2 and 5a4f45a doesn't apply.

konsumer commented 6 years ago

I'm not sure I understand the point of this PR. It looks like it's mostly moving the netlify script tag to the head, but not the other ones. Can you explain what this PR solves?

FMGordillo commented 6 years ago

It solves issue #8 as I mentioned in the issue itself and in the PRs title 😋

On Fri, Aug 31, 2018, 2:18 PM David Konsumer notifications@github.com wrote:

I'm not sure I understand the point of this PR. It looks like it's mostly moving the netlify script tag to the head, but not the other ones. Can you explain what this PR solves?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/konsumer/gatsby-starter-bootstrap-netlify/pull/9#issuecomment-417733098, or mute the thread https://github.com/notifications/unsubscribe-auth/AHmdfvze0RUc6RmzTsGzhiBE8zss5ffrks5uWW_cgaJpZM4WMiqv .

konsumer commented 6 years ago

Ah. Weird that the order matters, but I'm down.