search

kontalk / desktopclient-java

Kontalk official platform independent desktop client
https://www.kontalk.org
GNU General Public License v3.0
57 stars 24 forks source link

Wrong last seen time in chat history #82

Closed webratte closed 8 years ago

webratte commented 8 years ago

Kontalk: V 3.1.1 OS: Linux

Last seen should be updated from server like in Android client. Currently the last seen time seams to be the last sent or received time via Desktop client. Or what ever. I can't find what's really the shown time.

There are different times in contact list and chat history.

e.g my wife in this moment:

Android client: 27 minutes Desktop client chat history: 1 month Desktop client contact list: 21 houres

It's really strange ;-)

abika commented 8 years ago

The desktop client shows two different timestamps:

A "Last seen" time wouldn't make sense for group chats.

abika commented 8 years ago

oh wait, there is XEP-0012. Should use that.

webratte commented 8 years ago

there is no timestamp saved on the server

Please help to understand: I switch off my phone at 9 PM and switch it on at 7 AM If I take a look to my contacts I can see some of they was online between this time. So that only can be a information from server. Isn't it?

EDIT You was faster by answering then I by asking ;-)

webratte commented 8 years ago

The last activity in a chat is definitely different to Android client for all my contacts. I'm relative sure it's the time I have sent or received a message from desktopclient to this contact.

abika commented 8 years ago

So that only can be a information from server. Isn't it?

Yes, XEP-0012. Totally missed that but I will work on it.

The last activity in a chat is definitely different to Android client for all my contacts. I'm relative sure it's the time I have sent or received a message from desktopclient to this contact.

Yes, it's simply the time the last message was send/received in chat. There is no such time shown in the Android client.

webratte commented 8 years ago

Yes, XEP-0012. Totally missed that but I will work on it.

You was faster by answering then I by asking ;-)

Yes, it's simply the time the last message was send/received in chat. There is no such time shown in the Android client.

Maybe you should move this information to the chatballoon to make it more like in Android client. You see, it can be confusing for stupid users like me ;-)

webratte commented 8 years ago

Also for other things, I think the look and feel should more similar to the android client to make using of both clients more intuitive.

Fohroer commented 8 years ago

I agree with @webratte.

abika commented 8 years ago

@webratte XEP-0012 is implemented. The "last_seen" timestamp should be a lot more precise now.

@daniele-athome Basically on every (re-)connection I have to request the last_seen time for every (offline) contact. It feels like a lot of traffic for such a small information but there is no other way, right?

@webratte

Maybe you should move this information to the chatballoon to make it more like in Android client. You see, it can be confusing for stupid users like me ;-)

Actually there is a similar time for the last chat activity shown in the Android client: A date (e.g. "Sep 19") on the right side in the chat list. What you mean with "chatballoon"? The best way to prevent confusion is to remove this date in the chat list of the desktop client. But I don't like that either.

@webratte @Buranek There are tons of potential improvements for the UI. Most are small things that can still need a lot of implementation time. I'll make a list and open another issue.

webratte commented 8 years ago

Actually there is a similar time for the last chat activity shown in the Android client: A date (e.g. "Sep 19") on the right side in the chat list. What you mean with "chatballoon"? 

@abika exactly that. "A date (e.g. "Sep 19") on the right side in the chat list."

Chatballoon was the wrong term. Sorry, my mistake.

abika commented 8 years ago

How about this: switch the date with the one shown in the tooltip?

daniele-athome commented 8 years ago

@abika I think a "last activity" as in last message received (if I understood you correctly) is confusing for users coming from Android. Maybe you could change the label into "Last message"?

As for XEP-0012, unfortunately there is no other way besides requesting all of them at connect time, since it's IQ-based.

Fohroer commented 8 years ago

@abika This difference is extremely easy: Last online — is the time when user was online last time. Last message — is the time when you have sent a message to this user or this user has sent a message to you.

abika commented 8 years ago

Well, then "last message" instead of "last activity". But I will keep "last seen", the difference to "last online" is really small.

abika commented 8 years ago

XEP-0012 implemented and tooltip string changed. Will close this for now