search

kontalk / specs

Kontalk specifications and documentation
Other
21 stars 5 forks source link

XEP-0363: HTTP File Upload #12

Closed SafwatHalaby closed 8 years ago

SafwatHalaby commented 8 years ago

Conversations uses it and it works great.

SafwatHalaby commented 8 years ago

Xep link: http://xmpp.org/extensions/xep-0363.html

daniele-athome commented 8 years ago

Thanks for suggesting, we were looking into implementing that. Issue tracking can be found in the server repository, although I'll keep this to track modifications to the spec files.

abika commented 8 years ago

I'll add a Smack extension to client-common. We can already add support for incoming messages and move the upload part at a later time.

daniele-athome commented 8 years ago

@abika what do you mean? Incoming messages will be using out-of-band data (as it is now), only the upload part (read: the URL to upload to) will change. Or maybe I'm not getting your point?

abika commented 8 years ago

omg, yes. XEP-363 is only about the upload part, missed that.

In Conversations the link transfer from client-to-client is simply done by sending it inside the body:

...
<body>https://jabber.de:5281/upload/b818b5f5-8da4-41b4-9285-92e27a123456/IMG_20160119_1234.jpg</body>
...

And the OOB-Data extension is not supported (but it won't work with Kontalk's upload service, anyway).

daniele-athome commented 8 years ago

Why not include both? (URL in the body - for incompatible clients - and OOB - for clients who can understand what is going on). I will do the same in the Android client.

abika commented 8 years ago

yes, once the download doesn't require authorization anymore. Otherwise the (non-Kontalk) user can't open then link anyway.

daniele-athome commented 8 years ago

yes, once the download doesn't require authorization anymore. Otherwise the (non-Kontalk) user can't open then link anyway.

Exactly.

iNPUTmice commented 8 years ago

Why not include both? (URL in the body - for incompatible clients - and OOB - for clients who can understand what is going on). I will do the same in the Android client.

Conversations does exactly this. oob and body (for non encrypted messages that is)