kontalk / xmppserver-docker

Kontalk server Docker images
28 stars 14 forks source link

Avoid local build and use Docker Hub #13

Closed daniele-athome closed 6 years ago

daniele-athome commented 6 years ago

Building an image is quite expensive and time consuming, especially if we do that on a production server. Consider uploading images - even automatically through Travis CI - to Docker Hub for immediate pull and run. Things to address:

BRANCH build argument

The Dockerfile depends on build arguments, mainly the commit hash or branch name of the version to build. Since that would be the image tag, the Travis script would need to include that in the push command.

Launcher script

The launcher script would no longer build the image locally but it would pull it from Docker Hub. We should although keep the local build option in case we need it.

https://docs.travis-ci.com/user/docker/

Owner repository

This repository never changes when new commits of tigase-kontalk are produced. So the actual Travis build and docker push should happen in tigase-kontalk and not here.



https://hub.docker.com/r/kontalk/xmppserver/ https://hub.docker.com/r/kontalk/httpupload/

daniele-athome commented 6 years ago

httpupload doesn't change (like ever) so we are building it in the launcher script. The rest was implemented in 3a56270dc6e2319cc0a14727bf1b4beadb0f493c