search

kontena / kontena-websocket-client

Ruby websocket client library
Other
2 stars 11 forks source link

Depend on websocket-driver-kontena gem to avoid native extensions #12

Open SpComb opened 7 years ago

SpComb commented 7 years ago

See #11

Swap the websocket-driver dependency for websocket-driver-kontena, which excludes the native websocket_mask extension. The WebSocket::Driver will fall back to the pure-ruby websocket/mask implementation. The performance will presumably be worse.

TODO is to figure out how to support optionally installing the websocket_mask extension for those depending applications that are okay with installing native extensions.

SpComb commented 7 years ago

Benchmarking indicates that the websocket_mask extension has a fairly significant performance impact: #13

Merging this PR to drop the native extension would cut performance by roughly half, without some method to optionally install that extension.