search

kontena / kontena

The developer friendly container and micro services platform. Works on any cloud, easy to setup, simple to use.
https://www.kontena.io/
Apache License 2.0
1.47k stars 127 forks source link

Health check LB integration is missing interval #1516

Open jakolehm opened 7 years ago

jakolehm commented 7 years ago

https://cbonte.github.io/haproxy-dconv/configuration-1.5.html#5.2-inter

jnummelin commented 7 years ago

Should we use the same interval for LB checks also?

jakolehm commented 7 years ago

Not sure.. but now LB health check spam logs pretty hard (if service logs each request).

matti commented 7 years ago

yes, very hard:

2017-02-09T15:44:55.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:44:55 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:44:57.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:44:57 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:44:59.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:44:59 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:01.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:01 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:03.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:03 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:05.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:05 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:07.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:07 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:09.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:09 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:11.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:11 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:13.000Z [sentry.web-1]: 10.81.0.1 - - [09/Feb/2017:15:45:13 +0000] "GET /auth/login/sentry/ HTTP/1.1" 200 10904 "-" "Kontena-Agent/1.1.0"
2017-02-09T15:45:13.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:13 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:16.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:15 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:18.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:18 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
2017-02-09T15:45:20.000Z [sentry.web-1]: 10.81.128.62 - - [09/Feb/2017:15:45:20 +0000] "GET /auth/login/sentry/ HTTP/1.0" 200 10907 "-" "-"
jnummelin commented 7 years ago

IMO LB should do the checks more often than agent since it makes the balancing decisions based on the health.

matti commented 7 years ago

sure, but how to supress that spam?

jnummelin commented 7 years ago

that's up to the application. one way is to use a query param ?health and on the app side filter all those out from logs.