search

kontena / pharos-cluster

Pharos - The Kubernetes Distribution
https://k8spharos.dev/
Apache License 2.0
312 stars 43 forks source link

Kubernetes v1.10.5 #463

Closed jakolehm closed 6 years ago

jakolehm commented 6 years ago

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.10.md#changelog-since-v1104

Tested 1.10.5 but it seems to drop master taints.. needs more investigation.

SpComb commented 6 years ago

Tested 1.10.5 but it seems to drop master taints.. needs more investigation.

This looks relevant, but it should be fixing a bug where the master taint was incorrectly applied in 1.10.x: https://github.com/kubernetes/kubernetes/pull/64986

SpComb commented 6 years ago

Tested 1.10.5 but it seems to drop master taints.. needs more investigation.

Maybe this is #470?

SpComb commented 6 years ago

Upgrading to 1.10.5 without labels or taints set, the master taint is still there:

root@terom-pharos-master:~# kubectl get nodes/terom-pharos-master -o json | jq .spec
{
  "externalID": "terom-pharos-master",
  "podCIDR": "10.32.0.0/24",
  "taints": [
    {
      "effect": "NoSchedule",
      "key": "node-role.kubernetes.io/master"
    }
  ]
}
root@terom-pharos-master:~# kubectl version --short
Client Version: v1.10.5
Server Version: v1.10.5