phraos-etcd manifest version upgrade check is broken

kontena / pharos-cluster

Pharos - The Kubernetes Distribution

https://k8spharos.dev/

Apache License 2.0

312 stars 40 forks source link

Closed SpComb closed 6 years ago

SpComb commented 6 years ago

The configure-etcd.sh script incorrectly uses if [ ! func_call ] as a conditional, which is always false (the func_call string literal is never an empty string): https://github.com/kontena/pharos-cluster/blob/0561caa3470593b1d53fa1ea21073da68c6523e1/lib/pharos/scripts/configure-etcd.sh#L11

This prevents changes to ETCD_VERSION=... from triggering a new /etc/kubernetes/manifests/pharos-etcd.yaml write.

SpComb commented 6 years ago

The etcd_healthy check is also broken... there is no such function anymore.