kontena / pharos-cluster

Pharos - The Kubernetes Distribution
https://k8spharos.dev/
Apache License 2.0
311 stars 43 forks source link

Inconsistent relative path referencing for different commands #663

Closed kdomanski closed 5 years ago

kdomanski commented 5 years ago

https://github.com/kontena/pharos-cluster/blob/f969e7b54dec51fa5cd44904ab402417ab30ec0b/lib/pharos/up_command.rb#L41-L45

The snippet above changes the working directory in the up command, and that command only. This breaks the ability to specify an SSH key as a relative path, while working in a directory different than the config directory.

Example:

Working directory is /test and ssh_key_path = "../machine-key"

All versions since v0.6.0 are affected.

jnummelin commented 5 years ago

reset command changes the working dir the same way, but as you found out kubeconfig command does not.