kontena / pharos-host-upgrades

Kube DaemonSet for host OS upgrades
Apache License 2.0
41 stars 1 forks source link

Kube locks are missing an expiry mechanism #2

Open SpComb opened 6 years ago

SpComb commented 6 years ago

If the pod holding the upgrade lock crashes and is unable to release the lock, then it should expire automatically after some --lock-expiry=6h period, allowing other nodes to continue.

Currently, if the pod restarts after crashing, it will keep the lock acquired and retry the upgrade (once scheduled)... Might be better to ensure any running host-upgrades.service is stopped after restarting, and release the lock instead?