Resolve esbuild warnings

itworksafisher commented 4 days ago

Brief bug description

What went wrong?

After upgrading angular to v18 and using the new build system, which is esbuild instead of webpack, I see the following error.

▲ [WARNING] Calling "urlParse" will crash at run-time because it's an import namespace object, not a function [call-import-namespace]

    node_modules/@kontent-ai/delivery-sdk/dist/es6/utilities/delivery-url.helper.js:8:22:
      8 │     const parsedUrl = urlParse(url);
        ╵                       ~~~~~~~~

  Consider changing "urlParse" to a default import instead:

    node_modules/@kontent-ai/delivery-sdk/dist/es6/utilities/delivery-url.helper.js:1:7:
      1 │ import * as urlParse from 'url-parse';
        │        ~~~~~~~~~~~~~
        ╵        urlParse

Repro steps

Build an angular project which uses the delivery SDK and is using the newer esbuild.

Expected behavior

No warnings about urlParse.

Test environment

Platform/OS: node v22, angular v18

Additional context

Happens with both delivery-sdk v14 and v15.

itworksafisher commented 4 days ago

warning is considered valid via angular CLI. Any chance of using a default import instead of namespaced?

itworksafisher commented 4 days ago

https://github.com/angular/angular-cli/issues/28929

kontent-ai / delivery-sdk-js