kontent-ai / delivery-sdk-net

Kontent.ai Delivery .NET SDK
https://www.nuget.org/packages/Kontent.Ai.Delivery
MIT License
32 stars 41 forks source link

Multiple delivery client factory #347

Closed Simply007 closed 1 year ago

Simply007 commented 1 year ago

Motivation

Fixes #312 (replaced #333)

DEVREL-601

TODO

Checklist

How to test

If manual testing is required, what are the steps?

codecov[bot] commented 1 year ago

Codecov Report

Merging #347 (e564a2f) into master (2bad3d2) will decrease coverage by 0.05%. The diff coverage is 86.56%.

:exclamation: Current head e564a2f differs from pull request most recent head 14f16f1. Consider uploading reports for the commit 14f16f1 to get more accurate results

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   88.66%   88.60%   -0.06%     
==========================================
  Files         120      122       +2     
  Lines        2585     2651      +66     
  Branches      318      329      +11     
==========================================
+ Hits         2292     2349      +57     
- Misses        166      172       +6     
- Partials      127      130       +3     
Impacted Files Coverage Δ
...very.Abstractions/Configuration/DeliveryOptions.cs 100.00% <ø> (ø)
...ontent.Ai.Delivery.Caching/DeliveryCacheOptions.cs 100.00% <ø> (ø)
...ndencyInjection/NamedDeliveryClientCacheFactory.cs 84.44% <ø> (ø)
...n/Builders/MultipleDeliveryClientFactoryBuilder.cs 75.67% <75.67%> (ø)
...njection/Extensions/ServiceCollectionExtensions.cs 94.28% <100.00%> (+0.73%) :arrow_up:
...pendencyInjection/MultipleDeliveryClientFactory.cs 100.00% <100.00%> (ø)
....DependencyInjection/NamedDeliveryClientFactory.cs 93.18% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Simply007 commented 1 year ago

One last question - MultipleDleiveryClientFactory is OK?

Simply007 commented 1 year ago

Went through the comments -> is that alright @gormal?

gormal commented 1 year ago

Went through the comments -> is that alright @gormal?

Just nitpicking about formatting, please have a look.