kontent-ai / delivery-sdk-net

Kontent.ai Delivery .NET SDK
https://www.nuget.org/packages/Kontent.Ai.Delivery
MIT License
32 stars 41 forks source link

Issue/383 #385

Closed pokornyd closed 8 months ago

pokornyd commented 8 months ago

Motivation

Which issue does this fix? Fixes #383

Checklist

How to test

Initialize sync in your sample project, perform some changes, then get the token from initialization and run GetSyncAsync both with and without TypeProvider registered.

codecov[bot] commented 8 months ago

Codecov Report

Merging #385 (c726a1b) into master (d108042) will increase coverage by 0.01%. Report is 1 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   88.55%   88.57%   +0.01%     
==========================================
  Files         128      129       +1     
  Lines        2761     2774      +13     
  Branches      345      345              
==========================================
+ Hits         2445     2457      +12     
  Misses        185      185              
- Partials      131      132       +1     
Files Coverage Δ
Kontent.Ai.Delivery.Caching/DeliveryClientCache.cs 78.66% <ø> (ø)
Kontent.Ai.Delivery/DeliveryClient.cs 82.06% <100.00%> (+0.49%) :arrow_up:
Kontent.Ai.Delivery/Sync/DeliverySyncResponse.cs 62.50% <ø> (ø)
Kontent.Ai.Delivery/Sync/SyncItem.cs 100.00% <100.00%> (ø)
Kontent.Ai.Delivery/Sync/SyncItemData.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pokornyd commented 8 months ago

the model differed from the API response format, without mapping implemented to account for that. I adjusted the model to match sync API response, content item information is now nested in Data property.

a strongly typed item can be retrieved from newly introduced StronglyTypedData property, as long as a TypeProvider is registered and can found a suitable model. the property is null otherwise