kontent-ai / delivery-sdk-php

Kontent.ai Delivery SDK for PHP
https://kontent.ai
MIT License
46 stars 15 forks source link

Make linkedItems optional #107

Closed Simply007 closed 2 years ago

Simply007 commented 2 years ago

Motivation

Relates to #106.

Changes in #106 lead to a breaking change. Adding a parameter to the interface is a breaking change - to prevent this, it should be OK to make it optional.

Checklist

How to test

If manual testing is required, what are the steps?

codecov[bot] commented 2 years ago

Codecov Report

Merging #107 (dfc85fe) into master (22e2083) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage     98.13%   98.13%           
  Complexity      195      195           
=========================================
  Files            22       22           
  Lines           591      591           
=========================================
  Hits            580      580           
  Misses           11       11           
Impacted Files Coverage Δ
src/Kentico/Kontent/Delivery/DefaultMapper.php 98.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22e2083...dfc85fe. Read the comment docs.

Simply007 commented 2 years ago

Before closing - fix wiki page about the resolver

Simply007 commented 2 years ago

Let's keep it this way.