kontent-ai / delivery-sdk-php

Kontent.ai Delivery SDK for PHP
https://kontent.ai
MIT License
46 stars 15 forks source link

PHP 8 support #112

Closed jankonas closed 2 years ago

jankonas commented 2 years ago

Fixes #111

Checklist

How to test

API reference can be generated by running vendor/bin/phpdoc

codecov[bot] commented 2 years ago

Codecov Report

Merging #112 (2f09861) into master (9fb7eb8) will decrease coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #112      +/-   ##
============================================
- Coverage     98.13%   98.12%   -0.01%     
- Complexity      195      200       +5     
============================================
  Files            22       23       +1     
  Lines           591      588       -3     
============================================
- Hits            580      577       -3     
  Misses           11       11              
Impacted Files Coverage Δ
src/Kentico/Kontent/Delivery/DefaultMapper.php 98.43% <0.00%> (-0.03%) :arrow_down:
src/Kentico/Kontent/Delivery/UrlBuilder.php 100.00% <0.00%> (ø)
...rc/Kentico/Kontent/Delivery/ContentTypeFactory.php 100.00% <0.00%> (ø)
...entico/Kontent/Delivery/Models/Taxonomies/Term.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e3071b...2f09861. Read the comment docs.

Simply007 commented 2 years ago

Thank you for PR @jankonas,

I have briefly checked the changes and they look fine. I'll do a proper review next week and also try to validate the version release plan so that we don't need to release multiple major version close to each other.

Simply007 commented 2 years ago

I have updated https://github.com/Kentico/kontent-delivery-sdk-php/wiki/Doing-PHP-stuff-on-Windows-with-VS-Code accordingly to PHP 8