2nd review - Githubissues

kontent-ai / delivery-sdk-php

Kontent.ai Delivery SDK for PHP

https://kontent.ai

MIT License

46 stars 15 forks source link

Closed petrsvihlik closed 6 years ago

petrsvihlik commented 7 years ago

do a thorough review of the PHP SDK (especially of the content item retrieval/binding part)

dusekdan commented 6 years ago

I started reviewing the code, here is what I have to discuss so far:

We currently have ValueConverterInterface, TypeMapperInterface and PropertyMapperInterface, but I don't see any way to pass my own ValueConverter/TypeMapper/PropertyMapper implementation to ModelBinder. Is this what #42 is about?

I have currently reviewed about 40% of code.

petrsvihlik commented 6 years ago

you can pass the implementation to public properties of the DeliveryClient right after you construct it... shall we add it to the constructor? or what do you propose?

Simply007 commented 6 years ago

@dusekdan closed issue on the board - closing this one.