kontent-ai / delivery-sdk-php

Kontent.ai Delivery SDK for PHP

https://kontent.ai

MIT License

46 stars 15 forks source link

Collection implementation #92

Closed Simply007 closed 3 years ago

Simply007 commented 3 years ago

Motivation

91

Checklist

[x] Code follows coding conventions held in this repo
[x] Automated tests have been added
[x] Tests are passing
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Simply007 commented 3 years ago

Build filed cause - same as here: https://github.com/dbwebb-se/ramverk1/issues/13#issue-755375574

petrsvihlik commented 3 years ago

the https://github.com/xdebug/xdebug/pull/699 has already been released in https://github.com/xdebug/xdebug/releases/tag/3.0.1

what can we do to start using it? (update travis.yml or hardcode that dependency in composer.json?)

doesn't seem like we can influence the xdebug version...https://docs.travis-ci.com/user/languages/php/ ...or perhaps by running an extra script and providing an alternative configuration to PHP. which is not worth it at this point

petrsvihlik commented 3 years ago

don't forget to create an appropriate PR in

[ ] @Simply007 https://github.com/KenticoDocs/kontent-docs-samples/tree/master/php

Simply007 commented 3 years ago

I might have found a solution here: https://travis-ci.community/t/xdebug-3-is-installed-by-default-breaking-builds/10748/3

Setting XDEBUG_MODE=coverage should do the trick in travis configuration