search

kontent-ai / gatsby-starter

Gatsby starter site with Kontent.ai
https://gatsby-starter-kontent.netlify.com
MIT License
16 stars 23 forks source link

Use yarn instead of npm #31

Closed Simply007 closed 4 years ago

Simply007 commented 5 years ago

Motivation

When generating a new project based on this starter - the warning is showed up:

warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

Proposed solution

Use yarn instead of npm and remove package-lock.json

Additional context

Mind updating the Readme.md. The bootstrapped project is containing package,json and also yarn.lock file.

JanLenoch commented 5 years ago

Is Yarn capable of properly merging edits of package-lock.json made in two simultaneously running git branches? If yes, I'd vote for that too. Otherwise I'm not sure if it helped in such situations.

Simply007 commented 5 years ago

yarn is not using package-lock.json, it is using yarn.lock file.

it is necessary to remove package-lock.json and run yarn command to install dependencies and generate yarn.lock file. And it is required to adjust the Readme.md file according to the setup.

It would be best to configure Netlify checks to run yearn as well to have all configuration consistent.

Simply007 commented 5 years ago

Yarn was not implemented in referenced pull request - let's leave it opened.

tom-raley commented 4 years ago

Was this ever addressed? If not, I'd like to give it a go.