kontent-ai / java-packages

Delivery Java SDK for Kontent.ai including examples for Spring, Gradle, Kotlin and Java Android app
https://kontent.ai/learn/tutorials/develop-apps/overview/?tech=java
MIT License
14 stars 28 forks source link

Adding a get sync getItems method #112

Closed cunhazera closed 3 years ago

cunhazera commented 3 years ago

Fixes #109

Commentary:

Simply007 commented 3 years ago

This pull request only covers only the getItems method, but there is a bunch of remaining in the delivery client (i.e. getTypes).

I would like to avoid doubling the method count in the delivery client. I would appreciate a unified approach. It might be possible to inherit from CompletionStage and extend it with a method called toSync. This would not break any compatibility, because of inheritance and it would allow having nice and fluent syntax as described in https://github.com/Kentico/kontent-java-packages/issues/109#issuecomment-702618081.

According to the tests, I would like to not have current tests modified and just add new ones, because the functionality is also just added, not modified.

Mind the Readme - there should be the mention of the functionality too.

Simply007 commented 3 years ago

@cunhazera - do you have any update on this?

Simply007 commented 3 years ago

Hi!

This pull request has gone quiet. 👻 It’s been a while since the last update here.

If we missed anything on this issue or if you want to keep it open, feel free to do so.

Thanks for being a part of the Kentico community!