kontent-ai / java-packages

Delivery Java SDK for Kontent.ai including examples for Spring, Gradle, Kotlin and Java Android app
https://kontent.ai/learn/tutorials/develop-apps/overview/?tech=java
MIT License
14 stars 28 forks source link

add support for custom elements #118

Closed connyduck closed 3 years ago

connyduck commented 3 years ago

Motivation

Fixes #77

Checklist

Simply007 commented 3 years ago

Hello @connyduck!

Thanks for your contribution! I will try my best to check the pull request this week.

BTW: May I ask how did you find this issue? Are you working with Kentico Kontent and Android?

connyduck commented 3 years ago

We use the kontent delivery library in our Spring Boot backend and we have custom elements in our project.

Simply007 commented 3 years ago

@connyduck - are you willing to take a look at some notes I have noted above? I am willing to take a look at it and finish the feature, but I can't promise you a fixed date.

Your changes look OK and I am willing to merge the pull request and keep the issue open with the notes I have added above.

connyduck commented 3 years ago

@Simply007 I think I addressed everything Not sure why the CI is failing though

Simply007 commented 3 years ago

Let me check the CI.

Simply007 commented 3 years ago

I have removed the unused step that was failing (I am currently using a different approach to publish the versions).

I will take a look at the changes - but from my brief check, the changes look awesome @connyduck! Thanks for that :)

Is there any specific date you would like to have the functionality out? 🙂

connyduck commented 3 years ago

Thanks!

Is there any specific date you would like to have the functionality out? 🙂

No, but the sooner, the better of course!

Simply007 commented 3 years ago

Released in v4.3.0. Thanks, @connyduck - one of the smoothest cooperation lately.

I am about to mention this pull request in the upcoming Kentico Developer Flash!