Closed JerRMartin closed 2 years ago
Thank you for your edits!
Could you reformat
README.md
to keep its shape and just leave the Workflow step part addition?
I'm sorry, I don't know that I understood what you meant by this. Would you mind rewording it?
Thank you for your edits! Could you reformat
README.md
to keep its shape and just leave the Workflow step part addition?I'm sorry, I don't know that I understood what you meant by this. Would you mind rewording it?
Sure, In commit https://github.com/Kentico/kontent-java-packages/pull/139/commits/0567fb2ebddb5ef12b10ee38b2d80079c53042f2 you adjusted the readme with these changes which are completely correct.
But there are other changes that are changing the format of the README, like this one:
So I would like to have these other changes reverted.
Thank you for your edits! Could you reformat
README.md
to keep its shape and just leave the Workflow step part addition?I'm sorry, I don't know that I understood what you meant by this. Would you mind rewording it?
Sure, In commit 0567fb2 you adjusted the readme with these changes which are completely correct.
But there are other changes that are changing the format of the README, like this one:
So I would like to have these other changes reverted.
Sorry about that, it seems like the Markdown editor I used auto formatted the file without me noticing. Good Catch!
Hello @JerRMartin,
I have merged the PR and released 4.6.0-SNAPSHOT.
Could you test out, if everything works as expected on your particular project (the guide is here)?
Once confirmed, I can promote the snapshot to the production version.
Hello @JerRMartin,
I have merged the PR and released 4.6.0-SNAPSHOT.
Could you test out, if everything works as expected on your particular project (the guide is here)?
Once confirmed, I can promote the snapshot to the production version.
@Simply007 Looks Great! I'd say its ready to be promoted!
Version 4.6.0 is out!
https://repo1.maven.org/maven2/com/github/kentico/kontent-delivery/
Motivation
Which issue does this fix? N/A
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
adding in
workflow_step
field as part ofSystem
classworkflow_step
in the response, but Java SDK has no field to access this data on an initialized System Object.Checklist
[X] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[X] Tests are passing
[ ] Docs have been updated (if applicable)
[X] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults
How to test
If manual testing is required, what are the steps?
Step 1:
In the Main.java file, edit the
DeliveryOptions
on line 13 to target a test Kontent Project and to look like this:Step 2:
Rename
client
toclient2
on line 23, then remove the.getName()
from line 25, and reference an item in the test Kontent Project like so:Expected Results:
When targeting a test project with an unpublished element you should see a System object printed out displaying the
workflow_step
as one of the fields like so: