Closed Simply007 closed 1 year ago
DELIVERY SDK:
Kontent
instead of Kontent.ai
( comment suggestions in at least Readme are coming later with full review)Delivery-sdk-generators:
sample-app-android:
ArticlesFragment.java
it is not visible in the app though.sample-app-android-kotlin
sample-app-spring-boot:
coffee berages explained
clicking on so rich as today
should navigate us to the which brewing fits you?
articleParent:
DELIVERY SDK:
- [x] There are some
Kontent
instead ofKontent.ai
( comment suggestions in at least Readme are coming later with full review)- [ ] All .java files does not have updated MIT license on the top of the file
I haven't found any old licences
- [ ] Missing Javadocs (AsyncCache, Delivery client) - add or maybe create Issue?
Added for asynccache and delivery client - create issue for the rest
- [ ] Restructure folders -> sometimes it is hard to implementation of interface (optional, also candidate for new issue)
Create an issue if you want to
- [x] Code is mostly good from my perspective, some comments are coming with full review later
sample-app-spring-boot:
- [x] Change fonts to work sans
- [ ] Article.html has twice
I don't understand
- [x] Date in articles has weird format
- [x] Linked items in rich text element are not working.. In article
coffee berages explained
clicking onso rich as today
should navigate us to thewhich brewing fits you?
article
Motivation
Which issue does this fix? Fixes #
issue number
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?