Migrate to new organization - Githubissues

kontent-ai / java-packages

Delivery Java SDK for Kontent.ai including examples for Spring, Gradle, Kotlin and Java Android app

https://kontent.ai/learn/tutorials/develop-apps/overview/?tech=java

MIT License

14 stars 28 forks source link

Migrate to new organization #141

Closed Simply007 closed 1 year ago

Simply007 commented 1 year ago

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

IvanKiral commented 1 year ago

DELIVERY SDK:

[x] There are some Kontent instead of Kontent.ai ( comment suggestions in at least Readme are coming later with full review)
[ ] All .java files does not have updated MIT license on the top of the file
[x] Missing Javadocs (AsyncCache, Delivery client) - add or maybe create Issue?
[ ] Restructure folders -> sometimes it is hard to implementation of interface (optional, also candidate for new issue)
[x] Code is mostly good from my perspective, some comments are coming with full review later

IvanKiral commented 1 year ago

Delivery-sdk-generators:

[x] Code looks good, only there are some only Kontent mentions. Although there are only comments they can be changed with replace

IvanKiral commented 1 year ago

sample-app-android:

[ ] There is a Floating Action button registered in ArticlesFragment.java it is not visible in the app though.
[x] There are some not changed Kontent -> Kontent.ai

IvanKiral commented 1 year ago

sample-app-android-kotlin

[x] rename the gif from adroid -> android
[x] Kontent -> Kontent.ai (readme.md)

IvanKiral commented 1 year ago

sample-app-spring-boot:

[x] Change fonts to work sans
[ ] Article.html has twice <!DOCTYPE html>
[x] Date in articles has weird format
[x] Linked items in rich text element are not working.. In article coffee berages explained clicking on so rich as today should navigate us to the which brewing fits you? article

IvanKiral commented 1 year ago

Parent:

[x] There is a kontent-delivery folder with only empty readme

Simply007 commented 1 year ago

DELIVERY SDK:

[x] There are some Kontent instead of Kontent.ai ( comment suggestions in at least Readme are coming later with full review)

[ ] All .java files does not have updated MIT license on the top of the file

I haven't found any old licences

[ ] Missing Javadocs (AsyncCache, Delivery client) - add or maybe create Issue?

Added for asynccache and delivery client - create issue for the rest

[ ] Restructure folders -> sometimes it is hard to implementation of interface (optional, also candidate for new issue)

Create an issue if you want to

[x] Code is mostly good from my perspective, some comments are coming with full review later

Simply007 commented 1 year ago

sample-app-spring-boot:

[x] Change fonts to work sans

[ ] Article.html has twice

I don't understand

[x] Date in articles has weird format

[x] Linked items in rich text element are not working.. In article coffee berages explained clicking on so rich as today should navigate us to the which brewing fits you? article