search

kontent-ai / java-packages

Delivery Java SDK for Kontent.ai including examples for Spring, Gradle, Kotlin and Java Android app
https://kontent.ai/learn/tutorials/develop-apps/overview/?tech=java
MIT License
14 stars 28 forks source link

Provide DeliveryParameterBuilder.language(Locale language) method #28

Closed aweigold closed 7 years ago

aweigold commented 7 years ago

The parameter builder expects a string showing a Locale represented as "es-ES", build in support to allow a standard Java Locale to be passed in and perform conversion automatically.

cunhazera commented 7 years ago

@aweigold is there someone working on it?

aweigold commented 7 years ago

@cunhazera I can get it in today... easy task

cunhazera commented 7 years ago

@aweigold can you check the pull request referenced here? I could not solve that build problem

aweigold commented 7 years ago

@cunhazera I just saw the PR after I already commented. I'm looking at the build issue right now. There are some encrypted passwords/keys for deployment that travis does not expose in PR builds, it looks like I didn't condition to not try deploys on PRs.

cunhazera commented 7 years ago

Ok, I wait for your response. And please let me know if anything in the PR is not as you expected.

cunhazera commented 7 years ago

@aweigold I think that the issue can be closed now, right?

aweigold commented 7 years ago

@cunhazera yes it can, I'll close it now. Good work.