search

kontent-ai / management-sdk-net

Kontent.ai Management .NET SDK
https://www.nuget.org/packages/Kontent.Ai.Management
MIT License
7 stars 30 forks source link

Add support for X-KC-SDKID #222

Closed gormal closed 1 year ago

gormal commented 1 year ago

Motivation

Which issue does this fix? Fixes #197

Add support for X-KC-SDKID

How to test

Please test this for the model generator in self-contained mode. I expect that it might be problematic.

codecov-commenter commented 1 year ago

Codecov Report

Merging #222 (627896e) into master (be1a148) will decrease coverage by 0.78%. The diff coverage is 55.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   80.99%   80.22%   -0.78%     
==========================================
  Files         231      232       +1     
  Lines        2631     2710      +79     
  Branches      296      306      +10     
==========================================
+ Hits         2131     2174      +43     
- Misses        386      417      +31     
- Partials      114      119       +5
Impacted Files Coverage Δ
...gement/Attributes/SourceTrackingHeaderAttribute.cs 25.00% <25.00%> (ø)
...Modules/Extensions/HttpRequestHeadersExtensions.cs 67.50% <67.27%> (-1.74%) :arrow_down:
...Management/Modules/ActionInvoker/MessageCreator.cs 63.15% <100.00%> (+2.04%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gormal commented 1 year ago

Not sure how to tests assembly info though

Well in deliver SKD this solve problem is solved by exposing one of the private methods as internal. I personally don't like it but it's true, I didn't find a way to modify an assembly attribute dynamically, so only one configuration can be tested per project.

Simply007 commented 1 year ago

Not sure how to tests assembly info though

Well in deliver SKD this solve problem is solved by exposing one of the private methods as internal. I personally don't like it but it's true, I didn't find a way to modify an assembly attribute dynamically, so only one configuration can be tested per project.

I am OK with exposing the functionality to internal method.

gormal commented 1 year ago

I am OK with exposing the functionality to internal method.

Let's talk about it at today's meeting.