kontent-ai / model-generator-net

Kontent.ai .NET model generator.

https://www.nuget.org/packages/Kontent.Ai.ModelGenerator

MIT License

17 stars 19 forks source link

fixes #107 - Enable further customization of the CustomTypeProvider #111

Closed Sevitas closed 3 years ago

Sevitas commented 3 years ago

Motivation

Enables further customization of the CustomTypeProvider

Fixes #107

Checklist

[x] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[x] Tests are passing
[ ] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Check whether generated CustomTypeProvider contains:

GetType and GetCodename methods are marked as virtual
_codenames dictionary is marked as protected
valid C# code

codecov[bot] commented 3 years ago

Codecov Report

Merging #111 (770b3ed) into master (83a6202) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files          13       13           
  Lines         632      632           
  Branches       55       55           
=======================================
  Hits          514      514           
  Misses        101      101           
  Partials       17       17

Impacted Files	Coverage Δ
...t.ModelGenerator.Core/TypeProviderCodeGenerator.cs	`78.12% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83a6202...770b3ed. Read the comment docs.

MiroKentico commented 3 years ago

From my point of view, implementation is correct.

Sevitas commented 3 years ago

ity of the type provider? I would put the main information into Delivery SDK Wiki - probably this sec

It makes sense to put it into wiki and link it to the readme.

Sevitas commented 3 years ago

updated readme updated documentation @Simply007

Simply007 commented 3 years ago

updated readme updated documentation @Simply007

I have reverted the readme change - https://github.com/Kentico/kontent-generators-net/commit/31e02dd4310e70c402a6d631fb40287aa5b2005b + just adjusted link to wiki - I guess it is fine, we don!t want the same information on two places.

Rephrase in the wiki page to make it a bit more maintainable: https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Working-with-strongly-typed-models/_compare/c64ad99dd2c325a911617e3ad31a34269673b527...c0e09400372dc4e248e61fd25a5e113bfc3074e8

Sevitas commented 3 years ago

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

Simply007 commented 3 years ago

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

Make sence to me. Let's add it.

Sevitas commented 3 years ago

I've found another place link which might be edited (codesnippet). @Simply007 what do you think?

Make sence to me. Let's add it.

https://github.com/Kentico/kontent-delivery-sdk-net/wiki/Strong-Types-Explained-%E2%80%93-Code-Generator/_compare/27937f5138305cfbe8516eb7ee77927710614907...ff2584666e02a860e0d475ba822ec738cba89aba

Simply007 commented 3 years ago

Cool, let's merge it - @Sevitas - will you do the donors?