Issue #141: Added <auto-generated> tagged comments for each code file

kontent-ai / model-generator-net

Kontent.ai .NET model generator.

https://www.nuget.org/packages/Kontent.Ai.ModelGenerator

MIT License

17 stars 19 forks source link

Issue #141: Added <auto-generated> tagged comments for each code file #142

Closed jrkd closed 2 years ago

jrkd commented 2 years ago

BaseClassCodeGenerator/ClassCodeGenerator/TypeProviderCodeGenerator

Added a comment at the top of each file wrapped in the tag

ClassCodeGenerator

Also added a separate comment for the CustomPartial version of the generated files, as while it can be edited, it is still auto generated from the tool.

Motivation

Fixes #141

Checklist

[x] Code follows coding conventions held in this repo
[ ] Automated tests have been added (There arent tests for this project)
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Run the generator, and view the top of each file.

jrkd commented 2 years ago

Left few notes in the PR, however you should create a PR to the vNext branch, with the latest changes. There are also no tests for the functionality.

Ive updated as requested, and changed the merge target to vNext.

As for the tests, could you direct me to where tests should be placed in this project?

Sevitas commented 2 years ago

Left few notes in the PR, however you should create a PR to the vNext branch, with the latest changes. There are also no tests for the functionality.

Ive updated as requested, and changed the merge target to vNext.

As for the tests, could you direct me to where tests should be placed in this project?

Hi @jrkd, I've looked over the changes but I think changing the target branch will not be enough. You should first resolve merge conflicts or checkout the vNext branch locally and make these changes there (I think this might be easier, because there are lot of breaking changes in the project structure). Tests which should be edited can be found in the https://github.com/Kentico/kontent-generators-net/tree/vNext/test/Kentico.Kontent.ModelGenerator.Tests/Generators.

Sevitas commented 2 years ago

Closing. The original issue #141 will be fixed by #147. Thanks for the activity @jrkd.