kontent-ai / model-generator-net

Kontent.ai .NET model generator.
https://www.nuget.org/packages/Kontent.Ai.ModelGenerator
MIT License
17 stars 18 forks source link

Feature/90 known types #165

Closed Sevitas closed 1 year ago

Sevitas commented 1 year ago

Motivation

Fixes #90. Scenarios 1 and 2.

Checklist

How to test

Test that models are generated for senarios 1 and 2 and everything else works without a change.

Simply007 commented 1 year ago

I will redo the review and wait for tracking header support with that.

Simply007 commented 1 year ago

Mind the https://github.com/alanta/Kontent.Statiq/issues/21

codecov-commenter commented 1 year ago

Codecov Report

Merging #165 (07ad4ca) into master (47c09b1) will increase coverage by 1.32%. The diff coverage is 92.42%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   87.67%   89.00%   +1.32%     
==========================================
  Files          27       33       +6     
  Lines         860     1255     +395     
  Branches       80      128      +48     
==========================================
+ Hits          754     1117     +363     
- Misses         89      111      +22     
- Partials       17       27      +10     
Impacted Files Coverage Δ
...ontent.Ai.ModelGenerator.Core/CodeGeneratorBase.cs 48.71% <0.00%> (+0.61%) :arrow_up:
...nt.Ai.ModelGenerator.Core/DeliveryCodeGenerator.cs 71.92% <ø> (-2.76%) :arrow_down:
...ore/Generators/Class/DeliveryClassCodeGenerator.cs 100.00% <ø> (ø)
...Generators/Class/DeliveryClassCodeGeneratorBase.cs 100.00% <ø> (ø)
...Core/Generators/Class/PartialClassCodeGenerator.cs 100.00% <ø> (ø)
...c/Kontent.Ai.ModelGenerator/Options/UsedSdkInfo.cs 100.00% <ø> (ø)
src/Kontent.Ai.ModelGenerator/Program.cs 52.08% <11.11%> (-3.74%) :arrow_down:
...t.Ai.ModelGenerator.Core/Common/ClassDefinition.cs 86.84% <50.00%> (-13.16%) :arrow_down:
...i.ModelGenerator.Core/DeliveryCodeGeneratorBase.cs 84.00% <84.00%> (ø)
...delGenerator.Core/ExtendedDeliveryCodeGenerator.cs 87.17% <87.17%> (ø)
... and 15 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Simply007 commented 1 year ago

Please adjust https://github.com/kontent-ai/model-generator-net/blob/feature/90_known_types/src/Kontent.Ai.ModelGenerator/appSettings.json to respect new options and cover related tests if necessary.

Simply007 commented 1 year ago

I would emphasize the Api key with the example for the section: https://github.com/kontent-ai/model-generator-net/tree/feature/90_known_types#customizing-models---extended-delivery-models