Closed Sevitas closed 1 year ago
Let's try to avoid the breaking change. Leave the "True" value for the structured model as a possible solution, but deprecated.
- Once the user upgrade and uses
--structuredMode True
add logging that the value is deprecated- Note that to readme as well (and ideally mark it by
System.Obsolete
)
Should be fixed.
Merging #173 (ee359b5) into master (0afa18c) will increase coverage by
87.67%
. The diff coverage is91.11%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #173 +/- ##
===========================================
+ Coverage 0 87.67% +87.67%
===========================================
Files 0 27 +27
Lines 0 860 +860
Branches 0 80 +80
===========================================
+ Hits 0 754 +754
- Misses 0 89 +89
- Partials 0 17 +17
Impacted Files | Coverage Δ | |
---|---|---|
...nerator.Core/Configuration/CodeGeneratorOptions.cs | 85.71% <78.94%> (ø) |
|
.../Kontent.Ai.ModelGenerator.Core/Common/Property.cs | 96.77% <100.00%> (ø) |
|
...re/Configuration/CodeGeneratorOptionsExtensions.cs | 100.00% <100.00%> (ø) |
|
...delGenerator.Core/Helpers/DeliveryElementHelper.cs | 100.00% <100.00%> (ø) |
|
.../Kontent.Ai.ModelGenerator/ValidationExtensions.cs | 100.00% <100.00%> (ø) |
|
...Generators/Class/DeliveryClassCodeGeneratorBase.cs | 100.00% <0.00%> (ø) |
|
...t.Ai.ModelGenerator/ServiceCollectionExtensions.cs | 100.00% <0.00%> (ø) |
|
...rator.Core/Generators/TypeProviderCodeGenerator.cs | 84.12% <0.00%> (ø) |
|
src/Kontent.Ai.ModelGenerator/UsedSdkInfo.cs | 100.00% <0.00%> (ø) |
|
... and 21 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Motivation
Which issue does this fix? Fixes #172
Checklist
How to test
Generate structured elements for RT, DT. Generate elements without structured option.