Most important change is that I have removed regular expressions for striping whitespaces (new lines character) and set up equals method to ignore whitespaces and new line characters when checking equality:
I have tried to run tests on Linux Ubuntu and also on windows with various configurations of git core.autocrlf config key and I was not able to reproduce the issue, neither on the appveyor CI:
I have decided to not use the workaround with the regular expression. The Equals method should ignore line endings - if it doesn't, it is a bug of xunit and it needs to be submitted and resolved.
I have gone through the tests in files:
Most important change is that I have removed regular expressions for striping whitespaces (new lines character) and set up equals method to ignore whitespaces and new line characters when checking equality:
Then I have switched the order of parameters
Other commits are just some code polishing:
We have been discussing, that git configuration could influence how does the
Equalswork for xunit (https://github.com/Kentico/cloud-generators-net/pull/70).core.autocrlfconfig key and I was not able to reproduce the issue, neither on the appveyor CI:I have decided to not use the workaround with the regular expression. The
Equalsmethod should ignore line endings - if it doesn't, it is a bug of xunit and it needs to be submitted and resolved.