Feature/laravel 6 - Githubissues

nikspyratos commented 5 years ago

Motivation

Implements #8 - Laravel upgrade to 6.0

Checklist

[X] Code follows coding conventions held in this repo
[ ] Automated tests have been added (changes are minor and mostly to non-app logic files)
[X] Tests are passing
[X] Docs have been updated (if applicable)
[X] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Install the site on local, load the pages.

Simply007 commented 5 years ago

FYI: I was forced to place a workaround back: #13

How did you find this repository (or that specific issue)? Are you participating in Hacktoberfrest?

nikspyratos commented 5 years ago

Yeah, found it while searching around for php/Laravel Hacktoberfest stuff.

No conflicts between the workaround and this, so safe to merge whenever ready.

On Wed, Oct 9, 2019 at 9:56 AM Ondřej Chrastina notifications@github.com wrote:

FYI: I was forced to place a workaround back: #13 https://github.com/Kentico/kontent-sample-app-php/pull/13

How did you find this repository (or that specific issue)? Are you participating in Hacktoberfrest?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Kentico/kontent-sample-app-php/pull/12?email_source=notifications&email_token=AEIPMC6K2WCTLVZDVWMKDY3QNWFCTA5CNFSM4I6UMIQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAW72FI#issuecomment-539884821, or mute the thread https://github.com/notifications/unsubscribe-auth/AEIPMC7Y3BTGSIOZ6GJMLDLQNWFCTANCNFSM4I6UMIQQ .

Simply007 commented 5 years ago

Great @nikolaos-spyratos - thanks for sharing and the pull request itself!

Feel free to pick another issue, or contact via Gitter and we could find something else.

Check out Global collaborators dicsussions for some lat news about Kentico Open source activity.

kontent-ai / sample-app-php

Feature/laravel 6 #12

Motivation

Checklist

How to test