search

kontent-ai / sample-app-react

Sample React SPA utilizing the Kontent.ai Delivery API to fetch content.
https://kontent-sample-app-react.netlify.app/
MIT License
51 stars 73 forks source link

Update to latest React #180

Closed Simply007 closed 3 years ago

Simply007 commented 3 years ago

Motivation

The current implementation uses React 16, but the actual React version is at least 17.

Proposed solution

Upgrade to the newest React version and fix all the breaking changes.

Additional context

React 16 vs 17 https://github.com/facebook/react/blob/main/CHANGELOG.md

dunklesToast commented 3 years ago

I'll take a look at this!

dunklesToast commented 3 years ago

We could also upgrade the npm package-lock file to the latest version. It seems to have been generated with npm 6 or earlier. https://docs.npmjs.com/cli/v7/configuring-npm/package-lock-json#handling-old-lockfiles

Simply007 commented 3 years ago

Thanks @dunklesToast! The upgrade to v2 looks would be definitely useful. Can you add it to the pull request?

dunklesToast commented 3 years ago

I can either add it or create a new. Probably a new PR would be better since we address two different topics here? We could merge #182 then first.

Simply007 commented 3 years ago

Alright - let's split it. More PRs for you 👍🏼 I am gonna merge the first one and looking forward to the next one, after that, I will close this issue.