Feature/preview edit links

nkooman commented 1 year ago

Motivation

Which issue does this fix? Fixes #81

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious? This issue was created before Web Spotlight and the Smart Link SDK existed. The suggested solution called out manually creating and rendering edit links. Since the Smark Link SDK exists it became a lot easier to implement this functionality.

Checklist

[x] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[x] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

Create a sample Kontent environment. You will need to be able to configure spaces and preview URLs.
Configure the environment for preview mode in localhost.
Add the preview API key to your environment variables.
Run the site and view any page.

netlify[bot] commented 1 year ago

Deploy Preview for kontent-sample-app-react ready!

Name	Link
Latest commit	d24da83bc683946dea2ee7a336e1c44c902ea4c8
Latest deploy log	https://app.netlify.com/sites/kontent-sample-app-react/deploys/64f6a49c3840750008c8375f
Deploy Preview	https://deploy-preview-225--kontent-sample-app-react.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IvanKiral commented 1 year ago

Hey Nick! Thank you for the PR. 💯 I will put this review into my backlog :)

IvanKiral commented 1 year ago

Hey Nick! We are grateful for your PR.

Currently, we are working on a new sample project, which will cover the functionality of using Smartlink SDK. Therefore, your changes might be replaced in the near future (let's say something like in half a year).

If you would like to still to merge this PR, let us know. However, there are some things that need to be done, for example:

Let's find some better logic for invoking the Smartlink rather than always removing and adding the preview API key in envId.
- at least something similar to https://github.com/kontent-ai/sample-app-net
During preview in listing pages, you cannot get into article detail, which would be nice to handle
There are some technical nitpicks, like using any in Richtext,...

nkooman-bzs commented 1 year ago

If a new sample project is in the works, I think we can close this PR. Can't wait to see the new and improved version!

kontent-ai / sample-app-react