kontent-ai / sample-app-vue

A sample website written in JavaScript and Vue utilizing the Kontent.ai Delivery API to manage and retrieve content.
https://kontent-sample-app-vue.netlify.app
MIT License
24 stars 36 forks source link

Rebranding #101

Closed IvanKiral closed 2 years ago

IvanKiral commented 2 years ago

Motivation

Which issue does this fix? Fixes #issue number

Migration and rebranding

Checklist

How to test

If manual testing is required, what are the steps?

netlify[bot] commented 2 years ago

Deploy Preview for kontent-sample-app-vue ready!

Name Link
Latest commit df1fb684b5e0192dde648f0a79e4daebd379e5d6
Latest deploy log https://app.netlify.com/sites/kontent-sample-app-vue/deploys/630c665702ce64000980d473
Deploy Preview https://deploy-preview-101--kontent-sample-app-vue.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Simply007 commented 2 years ago

Upgrade will be done in #102

IvanKiral commented 2 years ago

I agree with the first one, there was one additional condition which made this error. The second one might be due to fallbacking into English language due to not published content in ES language.

Simply007 commented 2 years ago

I agree with the first one, there was one additional condition which made this error. The second one might be due to fallbacking into English language due to not published content in ES language.

In that case, there should be ˙https://deploy-preview-101--kontent-sample-app-vue.netlify.app/en-US/coffees/kenya-gakuyuni-aa˙ (with language codename right). The thing is we don't want to have the same content on different URLs. Not sure about the fallback - If we want to change the language prefix or keep it - but some should be present.

IvanKiral commented 2 years ago

I have updated the readme. Added a new paragraph about data fetching with an example, fixed grammar mistakes, and adjusted the structure of the whole readme