kontent-ai / sample-app-vue

A sample website written in JavaScript and Vue utilizing the Kontent.ai Delivery API to manage and retrieve content.
https://kontent-sample-app-vue.netlify.app
MIT License
24 stars 36 forks source link

refactor(configuration): update layout to match new ui #87

Closed MaximeKoitsalu closed 3 years ago

MaximeKoitsalu commented 3 years ago

Motivation

Which issue does this fix? Fixes #82

Checklist

How to test

If manual testing is required, what are the steps?

Make sure the new UI is identical to https://github.com/Kentico/kontent-sample-app-net/pull/128

MaximeKoitsalu commented 3 years ago

Ready to reviewed and merged

MaximeKoitsalu commented 3 years ago

Sure thing, I'll fix it tonight

MaximeKoitsalu commented 3 years ago

I scoped the styling to the Configuration.vue component, so that it is only affecting the body of that component.

Simply007 commented 3 years ago

I have checked the application and it still looks different mainly in fonts.

You can use the last published version for comparison (just click "use shared project" in configuration: https://kontent-sample-app-vue.netlify.app

With our deployment: https://deploy-preview-87--kontent-sample-app-vue.netlify.app/

image

MaximeKoitsalu commented 3 years ago

I have checked the application and it still looks different mainly in fonts.

You can use the last published version for comparison (just click "use shared project" in configuration: https://kontent-sample-app-vue.netlify.app

With our deployment: https://deploy-preview-87--kontent-sample-app-vue.netlify.app/

image

Ah I see, let me give it another go!

Simply007 commented 3 years ago

@MaximeKoitsalu - I guess this is ready for review right?

MaximeKoitsalu commented 3 years ago

@MaximeKoitsalu - I guess this is ready for review right?

Yes box :)!