Closed bjuppa closed 4 years ago
Ok, I'm going to change direction here one more time 😆
data-kontour-description
in addition to aria-label
and the CSS will take the description for the "tooltips".title
from buttons, perhaps we should put something like $controlAttributes
in there so buttons can be extended (This one needs some thinking as it may be easier to just write the html directly instead of pulling in a blade include).$buttonAttributes
!
This PR cleans up usage of the
title
html attribute that causes duplications in many screenreaders, and also it's not an accessible way to get a "tooltip".For links, the
name
anddescription
are now combined intoaria-label
, unless every word inname
is already present indescription
, if so onlydescription
is used to avoid duplication.The description is put into
data-kontour-description
and styling is also updated to display it as a tooltip when a link is hovered, focused or active.In addition the
data-kontour-username
is displayed as a tooltip on top for recent team links in the widget. Before this was only in attribute and never displayed visually in the interface.This PR contains breaking changes:
getLabel()
on theAdminLink
contract$description
for button Blade templates, so anyone using them needs to change it toaria-label
for same behaviour.Closes #145