kontenta / kontour

Admin page manager for Laravel
2 stars 1 forks source link

Support Laravel 9 & 10 #198

Closed bjuppa closed 1 year ago

bjuppa commented 2 years ago

Update the package with support for Laravel 9 & 10 and do new releases.

bjuppa commented 2 years ago

See #190 for info what was done last Laravel version bump!

bjuppa commented 1 year ago

Laravel 8 is end of life since January this year, so I'm planning to drop support for it in the next release.

This makes setting up the new CI with GitHub Actions in #200 a lot easier with a much smaller matrix.

bjuppa commented 1 year ago

In my first quick experiment with Laravel 10 the database is broken when running tests.

Check if something has gone awry in tests/IntegrationTestSetupTrait.php where we added an explicit sqlite :memory: connection to tests/IntegrationTestSetupTrait.php in #199.

See if this article can help: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/

bjuppa commented 1 year ago

To update the GitHub Actions for Laravel 10, see https://github.com/spatie/laravel-backup/blob/main/.github/workflows/run-tests.yml

erik-epineer commented 1 year ago

Started looking at the Laravel 10 upgrade yesterday, seems fine but I currently have a problem running the Dusk tests locally using my Docker setup. I'm trying to use the selenium/standalone-chrome image for this, but so far without any luck. @bjuppa how are you running those tests locally?

bjuppa commented 1 year ago

@erik-epineer in this package I'm actually just running the tests straight in the terminal, no docker. I've got PHP 8.2 on my local machine and whenever it complains about Chrome versions I just run ./vendor/bin/dusk-updater detect --auto-update and that fixes it.

Perhaps you can take a look at how https://github.com/laravel/sail makes Dusk tests work?

bjuppa commented 1 year ago

I've created a draft 2.1 release with Laravel 9 support: https://github.com/kontenta/kontour/releases/tag/untagged-4cfbc33506d42a9ee0c3

I think all is ready to publish that release!

bjuppa commented 1 year ago

Yeah, I asked myself if the release should be major (3.0) or minor (2.1) and I was thinking that the API of kontour itself hasn't changed and thus a major version bump wouldn't be required... 🤔 The compatibility with other package versions, even Laravel, is handled by composer anyway.

But now I'm thinking that the only other change apart from Laravel compatibility in this release is just a patch fixing the lang attribute... So with that reasoning we should just release 2.0.1 😄

bjuppa commented 1 year ago

I updated the draft release https://github.com/kontenta/kontour/releases/edit/untagged-21377ccece3e1f9e13b5

What do you think @erik-epineer, is 2.0.1 good?

erik-epineer commented 1 year ago

@bjuppa had the same thought just after I added my comment so deleted it. 😄 Let's go for 2.0.1, make sense!

bjuppa commented 1 year ago

There we go, 2.0.1 released! (and packagist already picked it up: https://packagist.org/packages/kontenta/kontour).

We'll keep this issue open until we released a version for Laravel 10!

erik-epineer commented 1 year ago

Ok, I've now added the PR for Laravel 10 support. See #202

erik-epineer commented 1 year ago

Ok, I've created a draft for the new 2.0.2 release here: https://github.com/kontenta/kontour/releases/edit/untagged-544cf8db2d6541f9ac2d

Ok to publish that one @bjuppa, or do you think there's some more information I should add?

bjuppa commented 1 year ago

Looks good @erik-epineer, please go ahead and publish the release! 👍

erik-epineer commented 1 year ago

@bjuppa ok done. Will close this issue now then.