search

kontron / python-ipmi

A pure python IPMI library
GNU Lesser General Public License v2.1
187 stars 74 forks source link

Added Handeling for 'target is None' ipmitool.py #123

Closed AliSot2000 closed 1 year ago

AliSot2000 commented 2 years ago

Revised Pull Request of the previous pull request. The Codacy Complaint should be addressed now.

hthiery commented 2 years ago

It would be great if you could meld this 2 commits into 1 commit.

https://stackoverflow.com/questions/2563632/how-can-i-merge-two-commits-into-one-if-i-already-started-rebase#:~:text=If%20you%20want%20to%20merge,commit%20name%20HEAD~2).&text=That%20will%20bring%20in%20the,them%20and%20you're%20done.

Then do a force push to your branch that will automatically update this PR. So you do not need to close and reopen a new PR.

Another thing is normally to add a "Signed-off-by" tag. It is optional but would also be good.

https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

The last thing: An unittest would be great.

https://github.com/kontron/python-ipmi/blob/master/tests/interfaces/test_ipmitool.py#L23

Thanks

AliSot2000 commented 2 years ago

Sorry for the wait. I've merged the commits (and the one for the unittest, which I added, as well), signed off the whole thing and force pushed the commit.

I hope it is up to spec.