Closed AliSot2000 closed 1 year ago
It would be great if you could meld this 2 commits into 1 commit.
Then do a force push to your branch that will automatically update this PR. So you do not need to close and reopen a new PR.
Another thing is normally to add a "Signed-off-by" tag. It is optional but would also be good.
https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for
The last thing: An unittest would be great.
https://github.com/kontron/python-ipmi/blob/master/tests/interfaces/test_ipmitool.py#L23
Thanks
Sorry for the wait. I've merged the commits (and the one for the unittest, which I added, as well), signed off the whole thing and force pushed the commit.
I hope it is up to spec.
Revised Pull Request of the previous pull request. The Codacy Complaint should be addressed now.