search

kontron / python-ipmi

A pure python IPMI library
GNU Lesser General Public License v2.1
185 stars 74 forks source link

Fix set user access optional byte #149

Closed canteuni closed 1 year ago

canteuni commented 1 year ago

The SetUserAccess command has an Optional byte for "User Session Limit" (Section 22.26 of IPMI spec). This byte should be set to 0x00 by default and not 0x01 as it was here before (my mistake).

Moreover, when testing on a OCP Leopard BMC (from Quanta), the SetUserAccess command fail with an error code Request data length invalid because this byte was not present in the request payload. This PR adds the possibility to set the "User Session Limit" and make sure this byte is always present in the request.

coveralls commented 1 year ago

Coverage Status

Coverage: 67.763% (-0.02%) from 67.779% when pulling a1f06376def4138c064edae12b92737d7c71fbe9 on canteuni:fix_set_user_access into f23395c3364ab03090e096ea336f910880f25798 on kontron:master.