Python 3 support complete

kontron / python-ipmi

A pure python IPMI library

GNU Lesser General Public License v2.1

187 stars 75 forks source link

Python 3 support complete #15

Closed Teslafly closed 8 years ago

Teslafly commented 8 years ago

Major changes:

Added support for python 3, tested on python 3.4 and 3.5

Minor changes:

Added serial mode to ipmitool interface module
Improved cc code error message
FRU write now checks to make sure correct byte # written
Parsed FRUDataField objects now remember their offset
General code cleanup, bug/typo fixes

coveralls commented 8 years ago

Coverage increased (+0.2%) to 66.81% when pulling b34fdfc32fd4bfd69d9b44f9a0dcffd2cd116e6a on Teslafly:kontron_master_pull into 2c2137c398da5a53f4f9aa3c56191884c23c14ac on kontron:master.

coveralls commented 8 years ago

Coverage increased (+0.2%) to 66.81% when pulling 364023c8362e6fbb20483bd915bc40583c23f0c0 on Teslafly:kontron_master_pull into 2c2137c398da5a53f4f9aa3c56191884c23c14ac on kontron:master.

coveralls commented 8 years ago

Coverage increased (+0.2%) to 66.763% when pulling 2ea0a0eb12e722dcdef702a585112b2c105c0651 on Teslafly:kontron_master_pull into 2c2137c398da5a53f4f9aa3c56191884c23c14ac on kontron:master.

Teslafly commented 8 years ago

It appears setup.py still has some bugs in python 3 I didn't catch. (but appears to work fine in py2) Do you want the fixes here? or somewhere else?

also, unless it fixed it wrong, it appears the version label used is now looking to be enforced. /usr/lib/python3/dist-packages/setuptools/dist.py:294: UserWarning: The version specified ('0.2.1-50-g2ea0a0e-dirty') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.

hthiery commented 8 years ago

Can you make a new pull request? Am 14.06.2016 20:37 schrieb "Teslafly" notifications@github.com:

It appears setup.py still has some bugs in python 3 I didn't catch. (but appears to work fine in py2) Do you want the fixes here? or somewhere else?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/kontron/python-ipmi/pull/15#issuecomment-225975696, or mute the thread https://github.com/notifications/unsubscribe/AGRTUuGRYthDesI_utcQIYSTMz69jaj7ks5qLvTrgaJpZM4I0vs5 .