search

kontron / python-ipmi

A pure python IPMI library
GNU Lesser General Public License v2.1
187 stars 75 forks source link

Utilization of event data fields in SelEntry class #69

Closed Arcticae closed 4 years ago

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.1%) to 75.02% when pulling 174e8bd225124e26b92e677af07ebde5a4c77ca4 on Arcticae:master into 0121bb007b2407e4103799cbec0a78bcae6413bc on kontron:master.

Arcticae commented 5 years ago

It's the same way i did it in the previous PR, and IPMI documentation defines these 3 variables as 3 separate fields, so i thought it would be more readable that way, although array would be fine with me too. If you think it's more convenient, let me know and i'll edit the PR.

hthiery commented 5 years ago

yes ... sorry for the confusion. I think it would be better to have these kind a values as list/array like value

Arcticae commented 4 years ago

@hthiery I've changed event_data to store it as an array of integers (more useful for further decoding than plain string), and also corrected the event_type decoding, as it was only taking 6 younger bits of the event (mask was 0x3f), instead of 7 (now mask is 0x7f). Would appreciate if you reviewed the changes and merged them :)